New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(provider): migrate gitlab provider to ts #4929
Merged
balazsorban44
merged 1 commit into
nextauthjs:main
from
yoannfleurydev:feat/gitlab-provider-to-ts
Jul 17, 2022
Merged
feat(provider): migrate gitlab provider to ts #4929
balazsorban44
merged 1 commit into
nextauthjs:main
from
yoannfleurydev:feat/gitlab-provider-to-ts
Jul 17, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
yoannfleurydev
force-pushed
the
feat/gitlab-provider-to-ts
branch
from
July 14, 2022 07:53
f051b95
to
40adf75
Compare
ubbe-xyz
approved these changes
Jul 14, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 💚
ubbe-xyz
reviewed
Jul 14, 2022
yoannfleurydev
force-pushed
the
feat/gitlab-provider-to-ts
branch
from
July 14, 2022 19:57
40adf75
to
bc58973
Compare
mshd
reviewed
Jul 15, 2022
mshd
approved these changes
Jul 15, 2022
yoannfleurydev
force-pushed
the
feat/gitlab-provider-to-ts
branch
3 times, most recently
from
July 15, 2022 13:03
01f40ed
to
cd8a6a0
Compare
yoannfleurydev
force-pushed
the
feat/gitlab-provider-to-ts
branch
from
July 16, 2022 11:58
cd8a6a0
to
88e1927
Compare
yoannfleurydev
force-pushed
the
feat/gitlab-provider-to-ts
branch
from
July 16, 2022 16:39
88e1927
to
534191f
Compare
balazsorban44
approved these changes
Jul 17, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤘 Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☕️ Reasoning
Migrate the GitLab provider to TypeScript. Better for type safety, avoid conflicts in projects that depends of NextAuth as mentioned in #4728
🧢 Checklist
🎫 Affected issues
Related to a discussion: #4728
Fixes: #4728
📌 Resources