Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(provider): migrate gitlab provider to ts #4929

Merged

Conversation

yoannfleurydev
Copy link
Contributor

@yoannfleurydev yoannfleurydev commented Jul 14, 2022

☕️ Reasoning

Migrate the GitLab provider to TypeScript. Better for type safety, avoid conflicts in projects that depends of NextAuth as mentioned in #4728

🧢 Checklist

  • Documentation
  • Tests
  • Ready to be merged

🎫 Affected issues

Related to a discussion: #4728

Fixes: #4728

📌 Resources

@vercel
Copy link

vercel bot commented Jul 14, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
next-auth ⬜️ Ignored (Inspect) Jul 16, 2022 at 4:39PM (UTC)

@github-actions github-actions bot added core Refers to `@auth/core` providers labels Jul 14, 2022
@yoannfleurydev yoannfleurydev marked this pull request as draft July 14, 2022 07:48
@yoannfleurydev yoannfleurydev marked this pull request as ready for review July 14, 2022 07:54
Copy link
Collaborator

@ubbe-xyz ubbe-xyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 💚

@yoannfleurydev yoannfleurydev force-pushed the feat/gitlab-provider-to-ts branch 3 times, most recently from 01f40ed to cd8a6a0 Compare July 15, 2022 13:03
Copy link
Member

@balazsorban44 balazsorban44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤘 Thanks!

@balazsorban44 balazsorban44 merged commit 2725d07 into nextauthjs:main Jul 17, 2022
@yoannfleurydev yoannfleurydev deleted the feat/gitlab-provider-to-ts branch July 17, 2022 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Refers to `@auth/core` providers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants