fix(signin.tsx): set type of built-in email sign-in input to "email" and add "required" attribute for browser validation #4352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to email for browse validation Currently, the built-in sign-in page has the wrong type (text) for the input for emails when using the magic link provider. Because of this a user can enter whatever they want in that input. By switching the type to be email we can make use of the browser provided validation and users will be forced to use properly formed emails addresses in order to sign-in.
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/nextauthjs/next-auth/EA2pfZwuVZ9dFnrcVKFJn76Sst8j |
raulmarindev
changed the title
|
@raulmarindev lets make it |
…n email input Currently, the built-in sign-in page doesn't have the required attribute for the input for emails when using the magic link provider. Because of this a user is able to submit the form without entering a value. By adding the "required" attribute we can make use of the browser provided validation and users will be forced to provide a value in order to sign-in.
|
@lluia Thank you both, I've added the required attribute |
raulmarindev
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasoning 💡
Currently, the built-in sign-in page has the wrong type (text) for the input for emails when using
the magic link provider. Because of this, a user can enter whatever value they want in that input and click on the "Sign in with Email". By switching the type to be "email" we can make use of the browser-provided validation and users will be
forced to use properly formed emails addresses in order to sign in.
Additionally, the built-in sign-in page doesn't have the required attribute for the input for emails when using the magic link provider. Because of this, a user is able to submit the form without entering a value. By adding the "required" attribute we can make use of the browser-provided validation and users will be forced to provide a value in order to sign in.
Checklist 🧢
Affected issues 🎟