Switch BattleNet to OIDC

[Stono]

Reasoning 💡

The current battlenet provider is broken, this switches it to a OIDC provider instead.

It switches it to a typescript file from a js file too.

Checklist 🧢

• Documentation
• Tests (tested locally)
• Ready to be merged

Affected issues 🎟

Fixes: #4013

[vercel]

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nextauthjs/next-auth/hSaq7uBf7MfqU9ACkGf6hzu5mZKw
✅ Preview: Canceled

[Deployment for 8571a03 canceled]

[Stono]

I'm new to next-auth btw so still finding my feet. I've noticed account linking only works when you have the same email address (and you're logged in when the flow starts).

Battlenet doesn't return an email address 🤷

I assume to do account linking here i need to wait for the api (next release?)

[balazsorban44]

Thanks, I left some comments to clean the config up.

As proof, could you also take a screenshot of your logged-in user so we know it actually works? Good to have as a future reference.

[balazsorban44]

I've noticed account linking only works when you have the same email address (and you're logged in when the flow starts).

This is correct. The default linking probably won't change, but you can use the adapter.linkAccout method (with proper security in mind on your side since it would be user-land code) however you like to connect accounts.

[Stono]

Can't show you my signed in user because i'm not actually allowing people to sign in with this, i'm trying a convoluted way to get account linking to work.

However here i've console logged out the details in the signin method so you can see it's working:

[Stono]

I've noticed account linking only works when you have the same email address (and you're logged in when the flow starts).

This is correct. The default linking probably won't change, but you can use the adapter.linkAccout method (with proper security in mind on your side since it would be user-land code) however you like to connect accounts.

Locally where would the most appropriate place for me to do that be? For context i'm trying to sign in using Credentials but then link several oauth'd accounts.

[balazsorban44]

Should be a discussion, not a comment on this PR 😉

[balazsorban44]

I standardized the changes of this PR in a follow-up commit here: 163149b

Basically, we should be using issuer cause that's the common reference in OAuth.

[codal-Jamie]

Running into id_token detected in the response, you must use client.callback() instead of client.oauthCallback() and the already mentioned issue with the Facebook provider too. Can the Facebook Provider also be updated to address the issue?