Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: only warn when using Twitter + OAuth 2.0 #4003

Merged
merged 1 commit into from Feb 18, 2022

Conversation

balazsorban44
Copy link
Member

@theobr reported this to me, thank you. We should only show the warning if the user opts into Twitter + OAuth 2.0, as their implementation is still somewhat subject to change.

In a future release, we can swap this warning to encourage people to use OAuth 2.0, so after that we can finally drop support for OAuth 1.0 support together with a 5-year-old 130kb dependency, decreasing the install size by ~40%!

I would like to entertain the idea that once we get the green light from Twitter to advertise their OAuth 2 over OAuth 1, we just bump to v5 and only require the user to install the oauth dependency only if they use Twitter 1.

The code is already pretty safe and would not block other users to decrease their bundle size.

Reasoning 💡

Checklist 🧢

  • Documentation
  • Tests
  • Ready to be merged

Affected issues 🎟

@vercel
Copy link

vercel bot commented Feb 17, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nextauthjs/next-auth/UtptxnASPCkb1mk393u8LZa8bCqK
✅ Preview: Canceled

@github-actions github-actions bot added the core Refers to `@auth/core` label Feb 17, 2022
Copy link
Contributor

@t3dotgg t3dotgg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this!!

@balazsorban44 balazsorban44 temporarily deployed to Preview February 17, 2022 20:54 Inactive
@github-actions
Copy link

🎉 Experimental release published on npm!

npm i next-auth@0.0.0-pr.4003.e7e3e60a
yarn add next-auth@0.0.0-pr.4003.e7e3e60a

@balazsorban44 balazsorban44 merged commit fb8874d into main Feb 18, 2022
@balazsorban44 balazsorban44 deleted the fix/twitter-oauth-2 branch February 18, 2022 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Refers to `@auth/core`
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants