DEV-3477-animate-on-the-contributions-dashboard-upgrade-prompt #1134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing run #5359 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
|||||||||||||||
…he-contributions-dashboard-upgrade-prompt
GuiMend
commented
May 29, 2023
spa/src/components/donations/DonationUpgradePrompts/DonationUpgradePrompts.test.tsx
Outdated
Show resolved
Hide resolved
Jest unit test coverage
|
nrh-cklimas
reviewed
May 30, 2023
spa/src/components/donations/DonationUpgradePrompts/DonationUpgradePrompts.tsx
Show resolved
Hide resolved
nrh-cklimas
approved these changes
May 31, 2023
x110dc
deleted the
DEV-3477-animate-on-the-contributions-dashboard-upgrade-prompt
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please fill out each section even if it's just with "N/A"
Plan? (if this draft/incomplete indicate what you intend to do and how)
What's this PR do?
Animate upgrade prompt show that it's more visible to the users.
Why are we doing this? How does it help us?
We want to make the upgrade prompt more visible for users.
How should this be manually tested? Please include detailed step-by-step instructions.
Did this PR make changes to the user interface that may require changes to the user-facing docs?
No
Have automated unit tests been added? If not, why?
Yes
How should this change be communicated to end users?
N/a
Are there any smells or added technical debt to note?
no
Has this been documented? If so, where?
no
What are the relevant tickets? Add a link to any relevant ones.
https://news-revenue-hub.atlassian.net/browse/DEV-3477
Do any changes need to be made before deployment to production (adding environment variables, for example)?
no
Are there next steps? If so, what? Have tickets been opened for them? List next-step tickets here:
no