Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow contributors to run docs site without env vars #845

Open
JohnTParsons opened this issue Apr 21, 2023 · 0 comments
Open

Allow contributors to run docs site without env vars #845

JohnTParsons opened this issue Apr 21, 2023 · 0 comments
Labels
story a user facing change triage This issue will be reviewed by the team

Comments

@JohnTParsons
Copy link
Collaborator

JohnTParsons commented Apr 21, 2023

Allow contributors to run docs site without env vars.

While working on CONTRIBUTING.md (here is the draft PR: #844), I noticed that README.md says, "> A few pages on the site use Google Sheets as a simple CMS, if you are contributing to the product you can request these variables from the team." Wouldn't be simpler and more secure if the docs site continued to work (as much as possible) even when no .env file containing secrets was present? Which was how it worked in early Jan.
Giving contributors access to LastPass doesn't seem like a good idea.

I suggest that we just return empty array IF env vars are not defined, instead of throwing CMSError. Only throw CMSError if CMS credentials don't work or they do work but data comes back in an unexpected format or missing some fields.

We could move checking that the env vars are set to the Circle CI step that does the docs site deployment. If not set, throw an error, instead of deploying, to make the pipeline fail.

@JohnTParsons JohnTParsons added the story a user facing change label Apr 21, 2023
@JohnTParsons JohnTParsons added the triage This issue will be reviewed by the team label Apr 21, 2023
@JohnTParsons JohnTParsons changed the title Container queries docs Allow contributors to run docs site without env vars Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
story a user facing change triage This issue will be reviewed by the team
Projects
Status: Ready to do
Development

No branches or pull requests

1 participant