Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Container queries - storybook changes #806

Open
jps opened this issue Apr 5, 2023 · 2 comments · May be fixed by #877
Open

Container queries - storybook changes #806

jps opened this issue Apr 5, 2023 · 2 comments · May be fixed by #877
Assignees
Labels
story a user facing change

Comments

@jps
Copy link
Contributor

jps commented Apr 5, 2023

Description

Looks like we should be able to proceed with this now as emotion-js/emotion#2876 has been closed

Spike outcome from before: https://nidigitalsolutions.jira.com/wiki/spaces/NPP/pages/4135977048/PPDSC-2238+CSS+Container+Queries

Previous PR: #400

Docs will be updated in separate ticket

Follow the suggestion from the PR and add storybook scenario for

  • GridLayout ( handleResponsiveProp function )
  • CardComposable
  • Block
  • TextBlock
  • Hidden and Visible

Add support for new units as per the PR

How do we want to document this

Business Benefit/Value

Allow consumers to use this new capability with NewsKit

Acceptance Criteria

As a user of the design system, I should be able to use container queries

@jps jps added triage This issue will be reviewed by the team story a user facing change labels Apr 5, 2023
@jps jps added this to the Component Enhancements milestone Apr 5, 2023
@jps jps removed the triage This issue will be reviewed by the team label Apr 5, 2023
@n-dorman n-dorman reopened this Apr 20, 2023
@jps
Copy link
Contributor Author

jps commented Apr 20, 2023

@jps create docs ticket and add

Update docs

Estimated at: 3 story points

@JohnTParsons JohnTParsons changed the title Container queries Container queries code changes Apr 21, 2023
@JohnTParsons JohnTParsons changed the title Container queries code changes Container queries storybook changes Apr 21, 2023
@JohnTParsons
Copy link
Collaborator

JohnTParsons commented Apr 21, 2023

Docs ticket created by James is: #840

@JohnTParsons JohnTParsons changed the title Container queries storybook changes Container queries - storybook changes Apr 21, 2023
@LukeFinch LukeFinch self-assigned this Apr 25, 2023
@LukeFinch LukeFinch linked a pull request Apr 27, 2023 that will close this issue
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
story a user facing change
Projects
Status: Peer review
4 participants