Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: use infra-checkers static analysis settings and bump go to 1.18 #333

Merged
merged 2 commits into from Aug 23, 2022
Merged

chore: use infra-checkers static analysis settings and bump go to 1.18 #333

merged 2 commits into from Aug 23, 2022

Conversation

sigilioso
Copy link
Contributor

No description provided.

@sigilioso sigilioso force-pushed the chore/static-analysis-settings branch from daa3a8a to cbafe9d Compare July 28, 2022 13:24
@sigilioso sigilioso marked this pull request as ready for review July 28, 2022 13:34
@sigilioso sigilioso requested a review from a team July 28, 2022 13:35
@kang-makes kang-makes marked this pull request as draft August 2, 2022 08:04
@sigilioso sigilioso marked this pull request as ready for review August 22, 2022 14:33
@sigilioso sigilioso force-pushed the chore/static-analysis-settings branch from cbafe9d to 72816bc Compare August 22, 2022 14:56
paologallinaharbur
paologallinaharbur approved these changes Aug 22, 2022
View reviewed changes
Copy link
Member

@paologallinaharbur paologallinaharbur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a nit and small doubts regarding the way go is setup

@sigilioso sigilioso merged commit 21711a2 into main Aug 23, 2022
@sigilioso sigilioso deleted the chore/static-analysis-settings branch August 23, 2022 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paologallinaharbur paologallinaharbur paologallinaharbur approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sigilioso @paologallinaharbur