feat: add filter capability to exclude events from being sent #376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dbudziwojskiNR I appreciate your feedback on this PR, thank you! |
|
Thank you @woehrl01 for your submission. We will talk to our Product Manager to determine when we can review the PR. |
woehrl01
force-pushed
the
exclude_filter
branch
from
4eb80d3
to
1f1d7a9
Compare
woehrl01
force-pushed
the
exclude_filter
branch
from
1f1d7a9
to
1ceea73
Compare
woehrl01
force-pushed
the
exclude_filter
branch
5 times, most recently
from
5d4eab2
to
5bd7073
Compare
woehrl01
force-pushed
the
exclude_filter
branch
from
5bd7073
to
c38d0fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds a new feature to be able to filter events being sent to NewRelic. It uses cached expressions via https://github.com/expr-lang/expr for minimal performance impact.
New configuration fields are
excludeEventsFilterandexcludeDescribeFilterwhich recieves an list of expression strings.Type of change
Checklist: