chore: use infra-checkers static analysis settings, bump go to 1.18 and bump dependencies #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sigilioso
changed the title
sigilioso
force-pushed
the
chore/static-analysis-settings
branch
from
cb0f08c
to
ab4c618
Compare
…nd bump dependencies
sigilioso
force-pushed
the
chore/static-analysis-settings
branch
from
ab4c618
to
27bdc9e
Compare
sigilioso
commented
Aug 23, 2022
| @@ -69,13 +69,18 @@ jobs: | |||
| runs-on: ubuntu-latest | |||
| steps: | |||
| - uses: actions/checkout@v2 | |||
| - uses: actions/setup-go@v2 | |||
| with: | |||
| go-version: '1.18' | |||
There was a problem hiding this comment.
Needed to use golangci-lint-action v3. Review this for details.
paologallinaharbur
approved these changes
Aug 23, 2022
| @@ -1,4 +1,4 @@ | |||
| FROM alpine:3.15.4 | |||
| FROM alpine:3.16.1 | |||
There was a problem hiding this comment.
(not related to the PR)
Sometimes we pin the patch and sometimes we do not, we should at some point agree on one approach.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.