chore: use infra-checkers static analysis settings and include known issue to trivyignore #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
sigilioso
changed the title
sigilioso
force-pushed
the
chore/static-analysis-settings
branch
2 times, most recently
from
e8eac45
to
055624e
Compare
sigilioso
changed the title
sigilioso
force-pushed
the
chore/static-analysis-settings
branch
from
055624e
to
1d50ff2
Compare
sigilioso
commented
Aug 23, 2022
| @@ -19,13 +19,18 @@ jobs: | |||
| runs-on: ubuntu-20.04 | |||
| steps: | |||
| - uses: actions/checkout@v2 | |||
| - uses: actions/setup-go@v2 | |||
| with: | |||
| go-version: ${{ env.GO_VERSION }} | |||
There was a problem hiding this comment.
it is needed when using golangci-lint-action v3, check this for details.
|
The title says bump alpine image version, but I do not see such change, did you forget to push it? (we could also merge one of the many already opened) |
I did not, but it was also updated in #53 , so after the rebase the change is not needed anymore, I'm updating the title to match the current changes. |
sigilioso
changed the title
paologallinaharbur
approved these changes
Aug 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.