Update for httprb 5.0.0 #722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amhuntsman
force-pushed
the
httprb_500_update
branch
from
e5f3f81
to
af85a21
Compare
|
Yikes -- I just noticed this on httprb's repo: httprb/http@efe274a I think it might be safe to say that HTTP 5.0 doesn't support jruby if the CI is not running against it. |
Oh yikes, yeah... Well at least we know it isn't our instrumentation causing the issue. I don't think they mentioned that in their changelog when I looked, so that's surprising. Since that's the case, all we need to do is exclude 5.0.0+ from running on jruby in multiverse. |
|
Nice. We might want to update the docs noting JRuby isn't supported for HTTP.rb 5.0.0+ as well. |
amhuntsman
force-pushed
the
httprb_500_update
branch
from
af85a21
to
0b9bfa2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before contributing, please read our contributing guidelines and code of conduct.
Overview
This PR fixes the breaking change httprb 5.0.0 introduces into our test suite, and adds that version back to our multiverse testing. The change made that caused the failures was related to this change httprb/http#546. Our instrumentation was not affected, but our test suite needed to be updated to create response objects correctly in 5.0.0.
Related Github Issue
closes #674
Testing
The agent includes a suite of unit and functional tests which should be used to
verify your changes don't break existing functionality. These tests will run with
Github Actions when a pull request is made. More details on running the tests locally can be found
here for our unit tests,
and here for our functional tests.
For most contributions it is strongly recommended to add additional tests which
exercise your changes.
Reviewer Checklist