Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix add_transaction_tracer ruby 3 deprecation warning #685

Merged
merged 1 commit into from May 19, 2021
Merged

Fix add_transaction_tracer ruby 3 deprecation warning #685

merged 1 commit into from May 19, 2021

Conversation

beauraF
Copy link
Contributor

@beauraF beauraF commented May 19, 2021 •
edited by tannalynn

Overview

Use ruby2_keywords to add ruby 3 support to NewRelic::Agent::Instrumentation::ControllerInstrumentation.add_transaction_tracer method, as recommended in this article.

Related Github Issue

#671

Reviewer Checklist

  • Perform code review
  • Add performance label
  • Perform appropriate level of performance testing
  • Confirm all checks passed
  • Add version label prior to acceptance

@CLAassistant
Copy link

CLAassistant commented May 19, 2021 •
edited

CLA assistant check
All committers have signed the CLA.

@angelatan2 angelatan2 added the community To tag external issues and PRs submitted by the community label May 19, 2021
@tannalynn tannalynn linked an issue May 19, 2021 that may be closed by this pull request
NewRelic::Agent::Instrumentation::ControllerInstrumentation .add_transaction_tracer method is missing **kwargs in its signature #671
Closed
tannalynn
tannalynn approved these changes May 19, 2021
View reviewed changes
Copy link
Contributor

@tannalynn tannalynn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the link to that article! That's great, and I agree that is the best way to do this. It's a simple change that works in all ruby versions, and keeps the tests passing as well. Looks great, thank you so much for submitting this PR, we really appreciate community contributions!

@tannalynn tannalynn merged commit e111069 into newrelic:dev May 19, 2021
@beauraF
Copy link
Contributor Author

beauraF commented May 19, 2021

Thank you so much for your kind words and reactivity @tannalynn!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tannalynn tannalynn tannalynn approved these changes

Assignees
No one assigned
Labels
community To tag external issues and PRs submitted by the community perf:startup version:7.1.0
Projects
None yet
Milestone
No milestone
4 participants
@beauraF @CLAassistant @tannalynn @angelatan2