Implement prepend instrumentation for Sinatra #626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR review checklist:
|
This was
linked to
issues
Mar 24, 2021
mwlang
suggested changes
Apr 1, 2021
mwlang
pushed a commit
that referenced
this pull request
Apr 5, 2021
* temp commit- added newline * enhanced multiverse to run prepend and chain instrumentation methods * support chaining and prepending instrumentation in the dependency manager; support new config options * handle our new instrumentation_value_of config helper method in the orphan config tests * removed unused variable assignment -- was throwing warnings that broke 2.7 runs * ability to override instrumentation's config key name * implemented Grape prepend * improving the multiverse test suite; added logging for instrumenting to dependency logic * fixed typo with configured_with * fixed Net::HTTP instrumentation * temp commit- added newline * enhanced multiverse to run prepend and chain instrumentation methods * support chaining and prepending instrumentation in the dependency manager; support new config options * handle our new instrumentation_value_of config helper method in the orphan config tests * removed unused variable assignment -- was throwing warnings that broke 2.7 runs * ability to override instrumentation's config key name * improving the multiverse test suite; added logging for instrumenting to dependency logic * fixed typo with configured_with * fixed Net::HTTP instrumentation * updating npm dependencies; fixing older mysqlclient installs * removed ruby 2.0 and 2.1 from CI * replace jruby CI exclusions * set up prepend for redis * added prepend instrumentation fot HTTPClient (#606) * DRY implementation for HTTPClient * Implement prepend instrumentation for Resque (#615) * set up prepend for resque * DRY resque tracing Co-authored-by: Michael Lang <mlang@newrelic.com> * DRY redis; consistent resque * Even more DRY implementation of Redis * fixed bug in namespace unit test; rekeyed the redis instrumentation configuration key to just 'redis' * deprecate the disabled redis config options * fixed the scanning for instrumentation_value_of in configuration file * implements Rack prepend * Using String now for the rack instrumentation settings * DRY the track_deferred_detection implementation * deprecated Mongo 1.x support * full namespace for Deprecator * removed redundant check on disabled instrumentation * Implement prepend instrumentation for Typhoeus (#612) * update typhoeus instrumentation and add prepend * more DRY implementation; changed naming to match other instrumentation conventions Co-authored-by: Michael Lang <mlang@newrelic.com> * add check to remove deprecated configs also * WIP: getting prepend to work * finishes memcache refactor for prepend and chain instrumentation * configuration clean up; removed redundant logged instrumentation messages * renamed memcached test folder to memecache to match library naming * Deprecate legacy excon instrumentation (#605) * deprecate legacy excon instrumentation * added check for allowed_by_config for excon * removed unneeded check * added new instrumentation config * added version to deprecate message * added deprecated method to old config * added deprecated flag to old disable_excon setting; full namespace on Deprecator Co-authored-by: Michael Lang <mlang@newrelic.com> * Implement prepend instrumentation for Curb (#577) * set up prepend for curb * updated config option * update test for both chain and prepend * update curb config * updated curb intrumentation * added missing file header * updated chain instrumentation for curb * added allowed_by_config? check for curb * made instrumentation more DRY * dprecating dalli_cas setting * Implement prepend instrumentation for Rake (#611) * reset up chain instrument for rake * added prepend * uncomment prepend for rake tests * updated config name * DRY implementation for Rake instrumentation Co-authored-by: Michael Lang <mlang@newrelic.com> * Implement prepend instrumentation for HTTP gem (#600) * add prepend for HTTP * updated config option for http instrumentation * update instrumentation for http gem * updated httprb instrumentation * renamed http files to httprb; consistent referencing of httprb; DRY implementation * added deprecated to the description for old config * increase timeout for CI Co-authored-by: Michael Lang <mlang@newrelic.com> * Implement prepend instrumentation for Delayed Job (#603) * added prepend for delayed job * updated delayed job instrumentation * add dynamic_name for config * changed second prepend to be 2.0 friendly * removed depends on for old config * updated instrumentation to be DRY * removed old activemerchant version * removed delayed job 2 * removed old versions of sidekiq * removed capistrano < 3.11 * removed old activemerchant versions < 1.62.0 * removed old versions of excon < 0.64.0 * removed testing for http < 2.2.2 * removed support for json versions < 2.2.0 * undo cap2 removal from multiverse * removed old versions of bunny and added newest * removed older redis versions * updated supported resque versions in test suite * removed old sequel versions * updated tested resque versions * updated tested sinatra versions * updated typhoeus versions being tested * removed older padrino versions being tested * add sidekiq version * newer resque versions only on 2.3+ * sinatra 2.1 on ruby 2.3+ * update sinatra rack versions * gated i18n version when on jruby due to jruby incompatibility with newer i18n * updated tested gems * removed padrino 0.13 from test suite * undo grape changes * Implement prepend instrumentation for Bunny (#599) * default prepend to true * add prepend for bunny * fox for bunny prepend * changed bunny prepend to module * updated bunny testing for chain and prepend * updated bunny * update bunny instrumentation * fix require_relative * reset default for config not related to bunny * added config check for bunny * DRYed up bunny instrumentation * fix leftover end * fix missing args * cleaned up and simplified Co-authored-by: Michael Lang <mlang@newrelic.com> * Implement prepend instrumentation for Sinatra (#626) * set up chain for sinatra * update sinatra instrumentation * added prepend file * drying up prepend changes * most tests passing * got prepend working * updated sinatra tests * updated tested versions * fix for sintra prepend build * updated unit tests for sintra instrumentation * updated deferred_instrumentation suite for sinatra * WIP added padrino * fix for padrino test app * changes based on code review * untangled includes/extends and simplify for better readability * fixed weird unintialized constant error * fix for unit test failures Co-authored-by: Michael Lang <mlang@newrelic.com> * fix test expectation * DRYed up the net_http instrumentation Co-authored-by: Michael Lang <mlang@newrelic.com> Co-authored-by: Aaron Huntsman <738047+amhuntsman@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before contributing, please read our contributing guidelines and code of conduct.
Overview
Updated Sinatra instrumentation to have both prepend and chain options hooked up and defaults to prepend.
Related Github Issue
closes #595