Don't start for 'rails runner' and 'rails db' #2623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add `Rails::Command::RunnerCommand` for `bin/rails runner` commands and `Rails::Command::RakeCommand` for `bin/rails db` command to the list of denylisted constants that will prevent the agent from autostarting when seen. Now when `bin/rails runner` and `bin/rails db` commands are ran, the agent will recognize those contexts and not start automatically. Older agent versions that are still supported by New Relic can update to the new list of denylisted constants by having the following line added to the `newrelic.yml` configuration file: ```yaml autostart.denylisted_constants: "Rails::Command::ConsoleCommand,Rails::Command::CredentialsCommand,Rails::Command::Db::System::ChangeCommand,Rails::Command::DbConsoleCommand,Rails::Command::DestroyCommand,Rails::Command::DevCommand,Rails::Command::EncryptedCommand,Rails::Command::GenerateCommand,Rails::Command::InitializersCommand,Rails::Command::NotesCommand,Rails::Command::RakeCommand,Rails::Command::RoutesCommand,Rails::Command::RunnerCommand,Rails::Command::SecretsCommand,Rails::Console,Rails::DBConsole" ```
fallwith
requested review from
hannahramadan,
kaylareopelle and
tannalynn
as code owners
SimpleCov Report
|
hannahramadan
approved these changes
May 3, 2024
kaylareopelle
approved these changes
May 3, 2024
This was referenced Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
Rails::Command::RunnerCommandforbin/rails runnercommands andRails::Command::RakeCommandforbin/rails dbcommand to the list of denylisted constants that will prevent the agent from autostarting when seen.Now when
bin/rails runnerandbin/rails dbcommands are ran, the agent will recognize those contexts and not startautomatically.
Older agent versions that are still supported by New Relic can update to the new list of denylisted constants by having the following line added to the
newrelic.ymlconfiguration file:resolves #2596