improve nonce unit test #2577
Merged
improve nonce unit test #2577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
fallwith
commented
Apr 18, 2024
fallwith
commented
- check for the exact ActionDispatch constant, not Rails
- escape the random characters ('+', etc.) that may interfere with regex matching
- use ///m for regex
- check for the exact ActionDispatch constant, not Rails
- escape the random characters ('+', etc.) that may interfere with regex
matching
- use ///m for regex
fallwith
requested review from
hannahramadan,
kaylareopelle and
tannalynn
as code owners
prevent `ensure` from being reached when the test is skipped
the `norails` env can pass the ActionDispatch detection check, so have it fail a separate Rails existence check as well
tannalynn
approved these changes
Apr 18, 2024
set a version constraint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.