Pin anyio version to below 4.0.0 #916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports MegaLinter is graciously provided by |
Codecov Report
@@ Coverage Diff @@
## main #916 +/- ##
==========================================
- Coverage 81.46% 81.45% -0.01%
==========================================
Files 186 186
Lines 18700 18700
Branches 3278 3278
==========================================
- Hits 15234 15233 -1
Misses 2533 2533
- Partials 933 934 +1 see 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
umaannamalai
approved these changes
Sep 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR pins framework_starlette: anyio to < v4.0.0
anyiois used fortest_exception_in_middlewaretest in Starlette: encode/starlette#1157However, v4.0.0 of
anyiocreates breaking changes to our tests (but not the instrumentation): https://github.com/agronholm/anyio/releases/tag/4.0.0This should be kept in our tests until Starlette v0.17.0 is no longer within New Relic's support window (January 23, 2024)