Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing K2 Integration #820

Draft
wants to merge 56 commits into
base: develop-k2-integration
Choose a base branch
from

Conversation

umaannamalai
Copy link
Contributor

Before contributing, please read our contributing guidelines and code of conduct.

Overview

Describe the changes present in the pull request

Related Github Issue

Include a link to the related GitHub issue, if applicable

Testing

The agent includes a suite of tests which should be used to
verify your changes don't break existing functionality. These tests will run with
Github Actions when a pull request is made. More details on running the tests locally can be found
here,
For most contributions it is strongly recommended to add additional tests which
exercise your changes.

1. Changes to start security module even before the agent is activated, thus, init on active_agent callback have been removed and instead added along with module load phase.
2. Updated agent refresh with policy and linking metadata along with agent config for security module
3. Removed deprecated security module configs constomer_id and accessor_token
@github-actions
Copy link

github-actions bot commented Jun 1, 2023

🦙 MegaLinter status: ❌ ERROR

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON bandit 3 0 6.29s
✅ PYTHON black 6 4 0 1.69s
❌ PYTHON flake8 6 1 0.78s
✅ PYTHON isort 6 4 0 0.27s
✅ PYTHON pylint 6 0 10.62s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@codecov-commenter
Copy link

Codecov Report

Merging #820 (3d44b8c) into develop-k2-integration (c2d4629) will decrease coverage by 3.17%.
The diff coverage is 85.71%.

❗ Current head 3d44b8c differs from pull request most recent head fe17e36. Consider uploading reports for the commit fe17e36 to get more accurate results

@@                    Coverage Diff                     @@
##           develop-k2-integration     #820      +/-   ##
==========================================================
- Coverage                   76.40%   73.24%   -3.17%     
==========================================================
  Files                         198      198              
  Lines                       19327    19369      +42     
  Branches                     3307     3308       +1     
==========================================================
- Hits                        14766    14186     -580     
- Misses                       3716     4268     +552     
- Partials                      845      915      +70     
Impacted Files Coverage Δ
newrelic/config.py 55.54% <64.70%> (+0.11%) ⬆️
newrelic/core/config.py 94.56% <100.00%> (+0.05%) ⬆️

... and 57 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mergify mergify bot added the tests-failing label Jun 1, 2023
@stale
Copy link

stale bot commented Aug 12, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Aug 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants