Add threading lock to TraceNode _cache #702
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦙 MegaLinter status: ✅ SUCCESS
See errors details in artifact MegaLinter reports on CI Job page MegaLinter is graciously provided by |
Since the dictionary is changing sizes during the attempted caching of the dictionary, this means it is being modified at the same time as it is being used. It is not just a matter of it changing sizes during a loop so it can't be addressed by a simple caching of the dictionary before looping). This will require a lock to prevent modification while it is being used. This adds a threading lock to the TraceNode so that the cache cannot be updated while it is being looped over (including while the cache is being cached).
hmstepanek
force-pushed
the
fix-size-change-bug
branch
from
7921349
to
9fe03df
Compare
|
Superseded by #704 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Adds lock to TraceNode _cache to prevent dict changed size during iteration error.
Related Github Issue
Fixes #663.