Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gRPC URI Detection #1137

Merged
merged 3 commits into from May 8, 2024
Merged

Fix gRPC URI Detection #1137

merged 3 commits into from May 8, 2024

Conversation

TimPansino
Copy link
Contributor

Overview

  • gRPC detection was picking up a new dns:/// prefix, stripping this before reporting the URI.

@TimPansino TimPansino requested a review from a team as a code owner May 8, 2024 18:05
Copy link

github-actions bot commented May 8, 2024

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON bandit 1 0 4.89s
✅ PYTHON black 1 0 0 0.75s
✅ PYTHON flake8 1 0 0.41s
✅ PYTHON isort 1 0 0 0.28s
✅ PYTHON pylint 1 0 2.19s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@mergify mergify bot added the tests-failing label May 8, 2024
@codecov-commenter
Copy link

codecov-commenter commented May 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.73%. Comparing base (8884497) to head (a9a11c6).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1137      +/-   ##
==========================================
+ Coverage   81.64%   81.73%   +0.08%     
==========================================
  Files         192      192              
  Lines       21304    21304              
  Branches     3706     3706              
==========================================
+ Hits        17394    17413      +19     
+ Misses       2832     2816      -16     
+ Partials     1078     1075       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mergify mergify bot removed the tests-failing label May 8, 2024
@TimPansino TimPansino merged commit df2b159 into main May 8, 2024
49 checks passed
@TimPansino TimPansino deleted the fix-grpc-uri-detection branch May 8, 2024 20:01
@TimPansino TimPansino added this to the v9.9.1 milestone May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants