Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add method to urllib3 trace #1130

Merged
merged 3 commits into from May 3, 2024
Merged

Add method to urllib3 trace #1130

merged 3 commits into from May 3, 2024

Conversation

lrafeei
Copy link
Contributor

@lrafeei lrafeei commented Apr 29, 2024

This PR explicitly adds http.method to urllib3 traces

Copy link

github-actions bot commented Apr 29, 2024

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON bandit 1 0 4.76s
✅ PYTHON black 2 0 0 0.87s
✅ PYTHON flake8 2 0 0.45s
✅ PYTHON isort 2 0 0 0.3s
✅ PYTHON pylint 2 0 2.19s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@codecov-commenter
Copy link

codecov-commenter commented Apr 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.67%. Comparing base (a447772) to head (7f138ca).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1130      +/-   ##
==========================================
- Coverage   81.74%   81.67%   -0.08%     
==========================================
  Files         192      192              
  Lines       21301    21301              
  Branches     3706     3706              
==========================================
- Hits        17413    17397      -16     
- Misses       2812     2826      +14     
- Partials     1076     1078       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lrafeei lrafeei marked this pull request as ready for review April 29, 2024 17:48
@lrafeei lrafeei requested a review from a team as a code owner April 29, 2024 17:48
@TimPansino
Copy link
Contributor

🚀

@lrafeei lrafeei merged commit 8b9e394 into main May 3, 2024
47 of 49 checks passed
@lrafeei lrafeei deleted the add-method-to-trace branch May 3, 2024 20:48
@mergify mergify bot removed the tests-failing label May 3, 2024
@TimPansino TimPansino added this to the v9.9.1 milestone May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants