Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Celery Instrumentation Cleanup #1128

Merged
merged 17 commits into from Apr 18, 2024
Merged

Conversation

TimPansino
Copy link
Contributor

Overview

  • Remove unnecessary instrumentation for Celery's build_tracer() function by patching compatibility with Celery's monkey-patching detection.
  • Add tests for all methods of running or enqueueing tasks in Celery.
  • Add additional logic for transaction naming for tasks run under map or starmap
  • Remove unused code and comments.

@TimPansino TimPansino requested a review from a team as a code owner April 18, 2024 21:08
Copy link

github-actions bot commented Apr 18, 2024

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON bandit 2 0 5.39s
✅ PYTHON black 8 0 0 2.16s
✅ PYTHON flake8 8 0 1.09s
✅ PYTHON isort 8 0 0 0.36s
✅ PYTHON pylint 8 0 6.27s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@lrafeei lrafeei added this to the v9.9.0 milestone Apr 18, 2024
@codecov-commenter
Copy link

codecov-commenter commented Apr 18, 2024

Codecov Report

Attention: Patch coverage is 72.41379% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 81.74%. Comparing base (3b46fad) to head (399f6da).

Files Patch % Lines
newrelic/hooks/application_celery.py 72.41% 6 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1128      +/-   ##
==========================================
- Coverage   81.77%   81.74%   -0.04%     
==========================================
  Files         192      192              
  Lines       21303    21300       -3     
  Branches     3707     3706       -1     
==========================================
- Hits        17420    17411       -9     
- Misses       2806     2813       +7     
+ Partials     1077     1076       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TimPansino TimPansino merged commit 7b90b64 into main Apr 18, 2024
49 checks passed
@TimPansino TimPansino deleted the fix-celery-instrumentation-cleanup branch April 18, 2024 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants