Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NEW_RELIC_K8S_OPERATOR_ENABLED #1127

Merged
merged 2 commits into from Apr 19, 2024

Conversation

hmstepanek
Copy link
Contributor

Overview

Add a configuration setting to indicate that the agent is being injected by the Kubernetes Agent Operator and that we should skip the python version safety check in sitecustomize.
See agent spec for details (open PR).

@hmstepanek hmstepanek requested a review from a team as a code owner April 17, 2024 23:31
Copy link

github-actions bot commented Apr 17, 2024

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON bandit 4 0 5.69s
✅ PYTHON black 10 0 0 2.23s
✅ PYTHON flake8 10 0 1.15s
✅ PYTHON isort 10 0 0 0.24s
✅ PYTHON pylint 10 0 7.25s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@hmstepanek hmstepanek changed the base branch from main to develop-k8s-agent-operator April 17, 2024 23:34
@codecov-commenter
Copy link

codecov-commenter commented Apr 18, 2024

Codecov Report

Attention: Patch coverage is 72.97297% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 81.73%. Comparing base (3b46fad) to head (fc7381a).

Files Patch % Lines
newrelic/hooks/application_celery.py 72.41% 6 Missing and 2 partials ⚠️
newrelic/bootstrap/sitecustomize.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@                      Coverage Diff                       @@
##           develop-k8s-agent-operator    #1127      +/-   ##
==============================================================
- Coverage                       81.77%   81.73%   -0.04%     
==============================================================
  Files                             192      192              
  Lines                           21303    21306       +3     
  Branches                         3707     3706       -1     
==============================================================
- Hits                            17420    17414       -6     
- Misses                           2806     2816      +10     
+ Partials                         1077     1076       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lrafeei
Copy link
Contributor

lrafeei commented Apr 18, 2024

I preemptively marked this as approved, but there's some test failures (mostly timeouts for some reason)

TimPansino and others added 2 commits April 18, 2024 14:59
* Rename files for better conventions

* Move worker config to conftest

* Update existing tests

* Add all celery task running methods to tests

* Patch celery name extraction crash

* Add correct metrics for all tests

* Fix map and starmap validators

* Fully corrected celery tests

* Remove celery tracer instrumentation

* Fix issue with wrappers not being detected by celery

* Add additional logic to celery task naming for mapping tasks

* Patch distributed tracing for new instrumentation point

* Expand celery testing matrix to all supported minor versions

* Remove unused code, and reorganize

* Linting

* Add another comment

* Remove all python 2 testing requirements
@mergify mergify bot removed the tests-failing label Apr 18, 2024
@hmstepanek hmstepanek merged commit 185f6f9 into develop-k8s-agent-operator Apr 19, 2024
49 checks passed
@hmstepanek hmstepanek deleted the add-config-option branch April 19, 2024 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants