Fix Laravel Lumen txn naming #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fahmy-Mohammed
commented
Apr 15, 2021
| @@ -36,6 +36,8 @@ static int nr_lumen_name_the_wt(const char* name TSRMLS_DC, | |||
| } else { | |||
| path += 1; | |||
| } | |||
| } else { | |||
| path = name; | |||
There was a problem hiding this comment.
This is needed otherwise the path is NULL when strip_base is set to false
|
Looks like the build failure is due to the 2 redis test failure that will be fixed soon. This should be good for a merge after another review 👍🏾 |
joshuabenuck
approved these changes
Apr 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes transaction naming for Laravel Lumen and adds a bit of cleanup.