Resolves various thread hop problems with Spring Reactor call chaining. #1883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d the FluxMapFuseable instrumentation to the reactor-3.3.0 module
This was
linked to
issues
May 3, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1883 +/- ##
============================================
- Coverage 70.68% 70.66% -0.03%
+ Complexity 9877 9876 -1
============================================
Files 828 828
Lines 39848 39848
Branches 6064 6064
============================================
- Hits 28167 28158 -9
- Misses 8954 8962 +8
- Partials 2727 2728 +1 ☔ View full report in Codecov by Sentry. |
jtduffy
approved these changes
May 6, 2024
meiao
reviewed
May 7, 2024
| } | ||
| } | ||
|
|
||
| public void run() { |
There was a problem hiding this comment.
Is this in a transaction?
Or is the method being instrumented after the first run? (due to token.link...() being called outside of a transaction)?
If it is the latter, we should add @Trace(async=true) to all these methods.
There was a problem hiding this comment.
Looks like the is working as intended without the @trace annotations added.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Grab a token when the SubscribeOnSubscriber is created and then link it when it is run().
Also copied this and the FluxMapFuseable instrumentation to the reactor-3.3.0 module.