Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Generic Event Handler Feature - Marks & Measures #852

Draft
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

metal-messiah
Copy link
Member

@metal-messiah metal-messiah commented Jan 3, 2024

Please add a one-paragraph summary here, suitable for a release notes description. This will help with documentation.

Overview

This PR introduces a generic event handlers as a feature, which expects event emitter messages, and uses them to merge events into a single payload and handles harvesting.

Related Issue(s)

https://whimsical.com/generic-event-handler-UAsH8LjzKvTndQnYLC6ftc

Testing

@metal-messiah metal-messiah added the POC A proof of concept label Jan 3, 2024
Copy link

github-actions bot commented Jan 3, 2024

Asset Size Report

Merging this pull request will result in the following asset size changes:

Agent Asset Previous Size New Size Diff
lite loader 31.44 kB / 11.03 kB (gzip) 31.51 kB / 11.07 kB (gzip) 0.22% / 0.32% (gzip)
lite async-chunk 50.96 kB / 16.57 kB (gzip) 51.63 kB / 16.73 kB (gzip) 1.3% / 0.97% (gzip)
pro loader 52.7 kB / 17.87 kB (gzip) 52.77 kB / 17.9 kB (gzip) 0.13% / 0.18% (gzip)
pro async-chunk 93.45 kB / 28.21 kB (gzip) 94.87 kB / 28.6 kB (gzip) 1.52% / 1.38% (gzip)
spa loader 60.81 kB / 20.37 kB (gzip) 60.88 kB / 20.41 kB (gzip) 0.12% / 0.19% (gzip)
spa async-chunk 108.72 kB / 32.63 kB (gzip) 110.13 kB / 33.02 kB (gzip) 1.3% / 1.19% (gzip)
lite-polyfills loader 125.44 kB / 40.32 kB (gzip) 125.51 kB / 40.36 kB (gzip) 0.06% / 0.1% (gzip)
lite-polyfills async-chunk 65.7 kB / 18.91 kB (gzip) 67.72 kB / 19.27 kB (gzip) 3.07% / 1.94% (gzip)
pro-polyfills loader 147.15 kB / 46.58 kB (gzip) 147.22 kB / 46.63 kB (gzip) 0.05% / 0.12% (gzip)
pro-polyfills async-chunk 113.96 kB / 30.15 kB (gzip) 118.29 kB / 31.09 kB (gzip) 3.8% / 3.12% (gzip)
spa-polyfills loader 155.35 kB / 48.75 kB (gzip) 155.42 kB / 48.79 kB (gzip) 0.05% / 0.08% (gzip)
spa-polyfills async-chunk 130.96 kB / 34.78 kB (gzip) 135.29 kB / 35.73 kB (gzip) 3.31% / 2.71% (gzip)

Copy link

codecov bot commented Jan 4, 2024

Codecov Report

Attention: Patch coverage is 15.11628% with 73 lines in your changes are missing coverage. Please review.

Project coverage is 86.68%. Comparing base (ff94cc2) to head (8cbb1eb).
Report is 1 commits behind head on main.

Files Patch % Lines
src/features/generic_event/aggregate/index.js 0.00% 37 Missing and 13 partials ⚠️
src/common/generic-events/marks-and-measures.js 0.00% 13 Missing and 1 partial ⚠️
src/common/generic-events/event-messenger.js 35.71% 7 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #852      +/-   ##
==========================================
- Coverage   87.38%   86.68%   -0.70%     
==========================================
  Files         156      159       +3     
  Lines        7100     7163      +63     
  Branches     1394     1409      +15     
==========================================
+ Hits         6204     6209       +5     
- Misses        779      824      +45     
- Partials      117      130      +13     
Flag Coverage Δ
unit-tests 75.63% <15.11%> (-0.34%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metal-messiah metal-messiah marked this pull request as ready for review January 4, 2024 16:26
@metal-messiah metal-messiah changed the title feat: [WIP] Generic event handler feat: Generic event handler feature Jan 4, 2024
@metal-messiah metal-messiah changed the title feat: Generic event handler feature feat: Generic Event Handler Feature Jan 4, 2024
@metal-messiah metal-messiah marked this pull request as draft January 8, 2024 17:24
@metal-messiah metal-messiah changed the title feat: Generic Event Handler Feature feat: Generic Event Handler Feature - Marks & Measures May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blocked POC A proof of concept
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant