Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Adjust session entity to not race between tabs #1032

Merged
merged 3 commits into from May 13, 2024
Merged

Conversation

metal-messiah
Copy link
Member

Allow first tab to fully instantiate a time correction to take precedence

Overview

Related Issue(s)

https://newrelic.slack.com/archives/C04QZSS6XPV/p1715357189958959

Testing

Existing tests have been updated

Copy link

github-actions bot commented May 13, 2024

Asset Size Report

Merging this pull request will result in the following asset size changes:

Agent Asset Previous Size New Size Diff
lite loader 31.44 kB / 11.02 kB (gzip) 31.44 kB / 11.02 kB (gzip) 0% / 0% (gzip)
lite async-chunk 51.05 kB / 16.61 kB (gzip) 50.97 kB / 16.57 kB (gzip) -0.17% / -0.22% (gzip)
pro loader 52.7 kB / 17.86 kB (gzip) 52.7 kB / 17.86 kB (gzip) 0% / 0% (gzip)
pro async-chunk 93.56 kB / 28.26 kB (gzip) 93.48 kB / 28.21 kB (gzip) -0.09% / -0.17% (gzip)
spa loader 60.82 kB / 20.36 kB (gzip) 60.82 kB / 20.36 kB (gzip) 0% / 0.01% (gzip)
spa async-chunk 108.82 kB / 32.69 kB (gzip) 108.74 kB / 32.65 kB (gzip) -0.08% / -0.12% (gzip)
lite-polyfills loader 125.46 kB / 40.32 kB (gzip) 125.46 kB / 40.32 kB (gzip) 0% / 0% (gzip)
lite-polyfills async-chunk 65.86 kB / 18.98 kB (gzip) 65.71 kB / 18.91 kB (gzip) -0.24% / -0.36% (gzip)
pro-polyfills loader 147.17 kB / 46.57 kB (gzip) 147.17 kB / 46.57 kB (gzip) 0% / 0% (gzip)
pro-polyfills async-chunk 114.14 kB / 30.22 kB (gzip) 113.98 kB / 30.16 kB (gzip) -0.14% / -0.21% (gzip)
spa-polyfills loader 155.36 kB / 48.74 kB (gzip) 155.36 kB / 48.75 kB (gzip) 0% / 0% (gzip)
spa-polyfills async-chunk 131.14 kB / 34.86 kB (gzip) 130.98 kB / 34.79 kB (gzip) -0.12% / -0.21% (gzip)

Copy link

codecov bot commented May 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.18%. Comparing base (84c101c) to head (a05dae2).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1032      +/-   ##
==========================================
- Coverage   87.21%   87.18%   -0.04%     
==========================================
  Files         156      156              
  Lines        7096     7100       +4     
  Branches     1398     1393       -5     
==========================================
+ Hits         6189     6190       +1     
- Misses        785      789       +4     
+ Partials      122      121       -1     
Flag Coverage Δ
integration-tests 91.15% <100.00%> (-0.01%) ⬇️
unit-tests 75.55% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented May 13, 2024

Static Badge

Last ran on May 13, 2024 15:29:19 CDT
Checking merge of (a05dae2) into main (84c101c)

Copy link
Member

@patrickhousley patrickhousley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved pending tests results

@metal-messiah metal-messiah merged commit d86becf into main May 13, 2024
51 checks passed
@metal-messiah metal-messiah deleted the timekeeper-fix branch May 13, 2024 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants