Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Audit timestamp flooring #1022

Merged
merged 8 commits into from May 15, 2024
Merged

chore: Audit timestamp flooring #1022

merged 8 commits into from May 15, 2024

Conversation

cwli24
Copy link
Contributor

@cwli24 cwli24 commented May 7, 2024


Overview

Clean up some usage of double precision performance.now() and make UI event soft navigations work with ms granularity.

Related Issue(s)

https://new-relic.atlassian.net/browse/NR-253743

Testing

Copy link

github-actions bot commented May 7, 2024

Asset Size Report

Merging this pull request will result in the following asset size changes:

Agent Asset Previous Size New Size Diff
lite loader 31.44 kB / 11.02 kB (gzip) 31.44 kB / 11.03 kB (gzip) -0.02% / 0.07% (gzip)
lite async-chunk 50.97 kB / 16.57 kB (gzip) 50.96 kB / 16.56 kB (gzip) -0.01% / -0.02% (gzip)
pro loader 52.7 kB / 17.86 kB (gzip) 52.7 kB / 17.87 kB (gzip) -0.01% / 0.04% (gzip)
pro async-chunk 93.48 kB / 28.21 kB (gzip) 93.43 kB / 28.2 kB (gzip) -0.04% / -0.03% (gzip)
spa loader 60.82 kB / 20.36 kB (gzip) 60.81 kB / 20.37 kB (gzip) -0.01% / 0.05% (gzip)
spa async-chunk 108.74 kB / 32.65 kB (gzip) 108.7 kB / 32.63 kB (gzip) -0.04% / -0.06% (gzip)
lite-polyfills loader 125.46 kB / 40.31 kB (gzip) 125.44 kB / 40.32 kB (gzip) -0.01% / 0.02% (gzip)
lite-polyfills async-chunk 65.71 kB / 18.91 kB (gzip) 65.7 kB / 18.9 kB (gzip) -0.01% / -0.02% (gzip)
pro-polyfills loader 147.17 kB / 46.57 kB (gzip) 147.15 kB / 46.58 kB (gzip) -0.01% / 0.02% (gzip)
pro-polyfills async-chunk 113.98 kB / 30.16 kB (gzip) 113.94 kB / 30.14 kB (gzip) -0.03% / -0.05% (gzip)
spa-polyfills loader 155.36 kB / 48.75 kB (gzip) 155.35 kB / 48.75 kB (gzip) -0.01% / -0.01% (gzip)
spa-polyfills async-chunk 130.98 kB / 34.79 kB (gzip) 130.94 kB / 34.77 kB (gzip) -0.03% / -0.04% (gzip)

Copy link

codecov bot commented May 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.14%. Comparing base (55b0e00) to head (2349a1c).
Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1022      +/-   ##
==========================================
+ Coverage   86.99%   87.14%   +0.14%     
==========================================
  Files         156      156              
  Lines        7087     7084       -3     
  Branches     1397     1413      +16     
==========================================
+ Hits         6165     6173       +8     
+ Misses        800      787      -13     
- Partials      122      124       +2     
Flag Coverage Δ
unit-tests 75.31% <100.00%> (-0.29%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented May 8, 2024

Static Badge

Last ran on May 13, 2024 09:49:48 CDT
Checking merge of (410a599) into main (55b0e00)

@cwli24 cwli24 changed the title feat: Increase time precision in agent internals chore: Audit timestamp flooring May 9, 2024
Copy link
Member

@patrickhousley patrickhousley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test failures need to be looked at.

@cwli24 cwli24 merged commit 77bf2b1 into main May 15, 2024
18 of 19 checks passed
@cwli24 cwli24 deleted the perf-now branch May 15, 2024 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants