Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Innovation bug bash #1010

Closed
wants to merge 3 commits into from
Closed

chore: Innovation bug bash #1010

wants to merge 3 commits into from

Conversation

metal-messiah
Copy link
Member

Please add a one-paragraph summary here, suitable for a release notes description. This will help with documentation.

Overview

Related Issue(s)

Testing

Copy link

github-actions bot commented May 2, 2024

Asset Size Report

Merging this pull request will result in the following asset size changes:

Agent Asset Previous Size New Size Diff
lite loader 31.73 kB / 11.1 kB (gzip) 31.73 kB / 11.1 kB (gzip) 0% / 0% (gzip)
lite async-chunk 50.97 kB / 16.58 kB (gzip) 50.97 kB / 16.58 kB (gzip) 0% / 0% (gzip)
pro loader 51.58 kB / 17.49 kB (gzip) 51.58 kB / 17.49 kB (gzip) 0% / 0% (gzip)
pro async-chunk 94.07 kB / 28.65 kB (gzip) 94.07 kB / 28.65 kB (gzip) 0% / 0% (gzip)
spa loader 59.49 kB / 19.92 kB (gzip) 59.49 kB / 19.92 kB (gzip) 0% / 0% (gzip)
spa async-chunk 109.13 kB / 33.05 kB (gzip) 109.13 kB / 33.05 kB (gzip) 0% / 0% (gzip)
lite-polyfills loader 125.55 kB / 40.36 kB (gzip) 125.55 kB / 40.36 kB (gzip) 0% / 0% (gzip)
lite-polyfills async-chunk 65.77 kB / 18.96 kB (gzip) 65.77 kB / 18.96 kB (gzip) 0% / 0% (gzip)
pro-polyfills loader 145.64 kB / 46.35 kB (gzip) 145.64 kB / 46.35 kB (gzip) 0% / 0% (gzip)
pro-polyfills async-chunk 129.53 kB / 33.84 kB (gzip) 129.53 kB / 33.84 kB (gzip) 0% / 0% (gzip)
spa-polyfills loader 153.62 kB / 48.48 kB (gzip) 153.62 kB / 48.48 kB (gzip) 0% / 0% (gzip)
spa-polyfills async-chunk 146.34 kB / 38.22 kB (gzip) 146.34 kB / 38.22 kB (gzip) 0% / 0% (gzip)

Copy link

codecov bot commented May 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.72%. Comparing base (b26215c) to head (3a3542d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1010   +/-   ##
=======================================
  Coverage   86.72%   86.72%           
=======================================
  Files         154      154           
  Lines        7125     7125           
  Branches     1419     1419           
=======================================
  Hits         6179     6179           
  Misses        823      823           
  Partials      123      123           
Flag Coverage Δ
unit-tests 74.23% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment on lines +6 to +7
const lk = 'NRBR-c7d7aa44f6c74d8ed93'
const a = 148790031
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably make these flags to be passed into the cli along with a flag to enable the forwarder.

@metal-messiah
Copy link
Member Author

closing with feature request --> https://new-relic.atlassian.net/browse/NR-270179

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants