Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[newrelic-pixie] Update newrelic-pixie chart to support ARM and include updates in nri-bundle #1198

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

ddelnano
Copy link

Update newrelic-pixie chart to support ARM and include updates in nri-bundle

Is this a new chart

No

What this PR does / why we need it:

Updates the newrelic-pixie-integration container image to a multi arch image including one of its dependencies (curl container)

Which issue this PR fixes

Special notes for your reviewer:

Testing done
Events:
  Type    Reason     Age   From               Message
  ----    ------     ----  ----               -------
  Normal  Scheduled  4m5s  default-scheduler  Successfully assigned newrelic/newrelic-pixie-c9bcx to aks-armpool-21043053-vmss000019
  Normal  Pulled     4m4s  kubelet            Container image "gcr.io/pixie-oss/pixie-dev-public/curl:multiarch-7.87.0@sha256:f7f265d5c64eb4463a43a99b6bf773f9e61a50aaa7cefaf564f43e42549a01dd" already present on machine
  Normal  Created    4m4s  kubelet            Created container cluster-registration-wait
  Normal  Started    4m4s  kubelet            Started container cluster-registration-wait
  Normal  Pulling    4m4s  kubelet            Pulling image "newrelic/newrelic-pixie-integration:2.2.0"
  Normal  Pulled     4m2s  kubelet            Successfully pulled image "newrelic/newrelic-pixie-integration:2.2.0" in 1.661279967s (1.661287247s including waiting)
  Normal  Created    4m2s  kubelet            Created container newrelic-pixie
  Normal  Started    4m2s  kubelet            Started container newrelic-pixie

# Job events
Events:
  Type    Reason            Age    From            Message
  ----    ------            ----   ----            -------
  Normal  SuccessfulCreate  4m50s  job-controller  Created pod: newrelic-pixie-c9bcx
  Normal  Completed         4m19s  job-controller  Job completed

Checklist

  • Chart Version bumped
  • Variables are documented in the README.md -- Not applicable
  • Title of the PR starts with chart name (e.g. [mychartname])

Signed-off-by: Dom Del Nano <ddelnano@pixielabs.ai>
Signed-off-by: Dom Del Nano <ddelnano@pixielabs.ai>
Signed-off-by: Dom Del Nano <ddelnano@pixielabs.ai>
Signed-off-by: Dom Del Nano <ddelnano@pixielabs.ai>
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@macnibblet
Copy link

Would love to see this merged 🙌

@giovannicandido
Copy link

I would like to see this merged. I'm using a mix or arm64 and x86_64 servers.

@ddelnano
Copy link
Author

I'm no longer at New Relic and won't be able to ensure this change gets merged. So another maintainer will have to help this change get through.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[newrelic-pixie] newrelic-pixie init container not running on arm64
4 participants