Zap Field Attributes Reporting #902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirackara
changed the title
mirackara
changed the title
iamemilio
reviewed
Apr 24, 2024
| @@ -582,6 +582,10 @@ type ApplicationLogging struct { | |||
| // Toggles whether the agent enriches local logs printed to console so they can be sent to new relic for ingestion | |||
| Enabled bool | |||
| } | |||
| ZapLogger struct { | |||
There was a problem hiding this comment.
Could we add more info here about when it makes sense to do this: We want to enable this when your app collects fewer logs, or if your app can afford to compile the json during log collection, slowing down the execution of the line of code that will write the log. Otherwise, if your application collects logs at a high frequency or volume, or it can not afford the slowdown of marshaling objects before sending them to newrelic, we can marahal them asynchronously in the backend during harvests
|
one nit pick, otherwise lgtm |
iamemilio
approved these changes
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for Zap field attributes properly showing up on the New Relic Platform.