Nrredis v9 #658
Merged
Nrredis v9 #658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gunturaf it looks like a number of valid failures occurred in the tests. Sorry about this, but would you mind taking a look and seeing if there are any implementation gaps that may be causing this? |
|
Alright, checking @iamemilio |
gunturaf
suggested changes
Mar 31, 2023
|
Something seems to be wrong with GH actions. Closing and re-opening to attempt a fix. |
|
@iamemilio can we get an ETA for this? |
|
This is a priority for our next release. We're doing our best to get it merged, but we have been having difficulties with our CI. |
Co-authored-by: Emilio Garcia <iamemilio@users.noreply.github.com>
fixes an nrreddis 9 bug that was caused by checking that a host was not equal to an empty string, rather than checking that it was equal to an empty string. Co-authored-by: Guntur Akhmad <gunturaf@gmail.com>
|
Rebased on develop latest, hopefully this will fix the tests |
|
|
|
I think you should sign the CLA to fix this pipeline @iamemilio ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submitting on behalf of @gunturaf. We merged #634 into master instead of develop, and had to undo. Merged PR's cannot be re-opened.
Author: @gunturaf