Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Json speed issue 505 #526

Merged
merged 4 commits into from Jun 29, 2022
Merged

Json speed issue 505 #526

merged 4 commits into from Jun 29, 2022

Conversation

nr-swilloughby
Copy link
Contributor

This PR addresses issue 505 by replacing the more expensive standard library json.Marshal calls with faster internal ones.

@nr-swilloughby nr-swilloughby self-assigned this Jun 28, 2022
@nr-swilloughby nr-swilloughby added this to Awaiting User Input in Go Engineering Board via automation Jun 28, 2022
iamemilio
iamemilio approved these changes Jun 29, 2022
View reviewed changes
Copy link
Contributor

@iamemilio iamemilio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Writing with the JsonX bytes buffer appender is definately MUCH faster than using the go standard library.

@nr-swilloughby nr-swilloughby merged commit 136f6b0 into develop Jun 29, 2022
Go Engineering Board automation moved this from Awaiting User Input to Done Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamemilio iamemilio iamemilio approved these changes

Assignees

@nr-swilloughby nr-swilloughby

Labels
None yet
Projects
Go Engineering Board
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nr-swilloughby @iamemilio