Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zerolog in Context #507
Zerolog in Context #507
Changes from 43 commits
b10a13e
9565130
8be7166
2fdbfbf
cc5e7cc
6b7c071
22adddd
514119b
d71870a
96b4b58
f0b6b53
69e13d2
c87eba3
eaef803
d4806f8
320057e
bcf0c6e
317b6a0
6ffb77a
138d1bd
1d326f4
7f28d60
3607461
d33379f
cbc801f
77fc73b
e6083ed
5594e30
6cf172d
2e6700e
0901501
f3b5b5b
561ab2d
900b6f4
9660625
ace7225
458f9d0
6f02ca7
1f766f4
814b1d6
33f7217
d916ec5
92a4a37
ad1a864
91ca115
d1385ff
f137814
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see span.id and trace.id being put on the log lines -- is there more enrichment that needs to be supported? Also, there are the three common attributes of entity GUID, entity name, and hostname.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By enrichment, I mean that we do not support enriching the local logs that get printed to console in this release. We add all of the enrichments to the logs, including entity GUID, entity name, and hostname at harvest