Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(errorsInbox): replace light mode screenshots with dark mode #17310

Merged
merged 4 commits into from
May 20, 2024

Conversation

ally-sassman
Copy link
Contributor

@ally-sassman ally-sassman commented May 14, 2024

This PR replaces a few lingering errors inbox screenshots from light mode to dark mode and updates the surrounding content to match the new UI.

@ally-sassman ally-sassman added content requests related to docs site content from_tw Identifies issues/PRs from Tech Docs writers labels May 14, 2024
@ally-sassman ally-sassman self-assigned this May 14, 2024
@github-actions github-actions bot requested a review from rhetoric101 May 14, 2024 22:57
Copy link

Hi @ally-sassman 👋

Thanks for your pull request! Your PR is in a queue, and a writer will take a look soon. We generally publish small edits within one business day, and larger edits within three days.

We will automatically generate a preview of your request, and will comment with a link when the preview is ready (usually 10 to 20 minutes).

@github-actions github-actions bot added this to Hero to triage in Docs PRs and Issues May 14, 2024
Copy link

netlify bot commented May 14, 2024

Deploy Preview for docs-website-netlify ready!

Name Link
🔨 Latest commit 08f1364
🔍 Latest deploy log https://app.netlify.com/sites/docs-website-netlify/deploys/66466643864e1a00080a7592
😎 Deploy Preview https://deploy-preview-17310--docs-website-netlify.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ally-sassman ally-sassman moved this from Hero to triage to In progress in Docs PRs and Issues May 14, 2024
Copy link
Contributor

@rhetoric101 rhetoric101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ally-sassman thanks for updating these screenshots. I'm not sure the new image for the attributes tab is actually for the attributes tab (src/images/errors-inbox_screenshot-crop_error-context2.webp). Could you confirm?

Also, I'm not seeing this image imported or referenced in the doc: src/images/errors-inbox_screenshot-full_users-impacted.webp

@ally-sassman ally-sassman merged commit 3f96c21 into develop May 20, 2024
18 checks passed
@ally-sassman ally-sassman deleted the errors-inbox-screenshots-update branch May 20, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content requests related to docs site content from_tw Identifies issues/PRs from Tech Docs writers
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants