New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(Publish 15 May 2024 at 9:00 AM) Logs: Add query time parsing rules #17276

Merged

rhetoric101 merged 17 commits into develop from rhs-query-time-parsing

May 15, 2024

Contributor

rhetoric101 commented May 11, 2024

No description provided.


          feat(logs) Add query time parsing rules

b789d48

rhetoric101 added content from_internal labels

rhetoric101 self-assigned this

github-actions bot commented May 11, 2024

Hi @rhetoric101 👋

Thanks for your pull request! Your PR is in a queue, and a writer will take a look soon. We generally publish small edits within one business day, and larger edits within three days.

We will automatically generate a preview of your request, and will comment with a link when the preview is ready (usually 10 to 20 minutes).

github-actions bot added this to Hero to triage in Docs PRs and Issues

netlify bot commented May 11, 2024 •

edited

✅ Deploy Preview for docs-website-netlify ready!

Name	Link
🔨 Latest commit	`7e6721c`
🔍 Latest deploy log	https://app.netlify.com/sites/docs-website-netlify/deploys/664404ea9a7ca40008deab8a
😎 Deploy Preview	https://deploy-preview-17276--docs-website-netlify.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

rhetoric101 moved this from Hero to triage to In progress in Docs PRs and Issues

rhetoric101 added 5 commits

May 13, 2024 16:42


          feat(logs): Add query time parsing images.

7d843a6


          feat(logs): Fix some missing images, broken syntax and wording

3421fb0


          feat(logs): Add internal anchor and add backticks

360eb80


          feat(logs): Remove rogue </tr> tag.

f7ba526


          fix(logs): Add contractions and remove bolding

5aa3486

rhetoric101 closed this

rhetoric101 reopened this

Docs PRs and Issues automation moved this from In progress to Hero to triage

rhetoric101 marked this pull request as ready for review

May 14, 2024 15:48

rhetoric101 moved this from Hero to triage to Needs review in Docs PRs and Issues

clarkmcadoo reviewed

View reviewed changes

src/content/docs/logs/ui-data/query-time-parsing.mdx Show resolved Hide resolved


          fix(logs): Query time parsing

7133aac

homelessbirds reviewed

View reviewed changes

src/content/docs/logs/ui-data/query-time-parsing.mdx Outdated Show resolved Hide resolved

homelessbirds reviewed

View reviewed changes

src/content/docs/logs/ui-data/query-time-parsing.mdx Outdated Show resolved Hide resolved

homelessbirds reviewed

View reviewed changes

src/content/docs/logs/ui-data/query-time-parsing.mdx Outdated Show resolved Hide resolved

homelessbirds reviewed

View reviewed changes

src/content/docs/logs/ui-data/query-time-parsing.mdx Outdated Show resolved Hide resolved

homelessbirds reviewed

View reviewed changes

src/content/docs/logs/ui-data/query-time-parsing.mdx Outdated Show resolved Hide resolved

homelessbirds reviewed

View reviewed changes

src/content/docs/logs/ui-data/query-time-parsing.mdx Show resolved Hide resolved

homelessbirds reviewed

View reviewed changes

src/content/docs/logs/ui-data/query-time-parsing.mdx Show resolved Hide resolved

homelessbirds reviewed

View reviewed changes

src/content/docs/logs/ui-data/query-time-parsing.mdx Show resolved Hide resolved

homelessbirds reviewed

View reviewed changes

src/content/docs/logs/ui-data/query-time-parsing.mdx Outdated Show resolved Hide resolved

homelessbirds reviewed

View reviewed changes

src/content/docs/logs/ui-data/query-time-parsing.mdx Show resolved Hide resolved

mchavez-newrelic reviewed

View reviewed changes

src/content/docs/logs/ui-data/query-time-parsing.mdx Outdated Show resolved Hide resolved

mchavez-newrelic reviewed

View reviewed changes

src/content/docs/logs/ui-data/query-time-parsing.mdx Outdated Show resolved Hide resolved

mchavez-newrelic reviewed

View reviewed changes

src/content/docs/logs/ui-data/query-time-parsing.mdx Outdated Show resolved Hide resolved

rhetoric101 and others added 3 commits

May 14, 2024 12:47


          fix(logs): Add SME and peer editing changes to doc.

b2317e8


          fix(logs): Correct typo in series.

5df16b3

Co-authored-by: mchavez-newrelic <132291725+mchavez-newrelic@users.noreply.github.com>


          feat(logs): Revamp intro and add image and wording to first step.

7c7e864

mchavez-newrelic reviewed

View reviewed changes

src/content/docs/logs/ui-data/query-time-parsing.mdx Outdated Show resolved Hide resolved

mchavez-newrelic reviewed

View reviewed changes

src/content/docs/logs/ui-data/query-time-parsing.mdx Outdated Show resolved Hide resolved

mchavez-newrelic reviewed

View reviewed changes

src/content/docs/logs/ui-data/query-time-parsing.mdx Outdated Show resolved Hide resolved

homelessbirds self-requested a review

May 14, 2024 21:58

homelessbirds previously approved these changes

View reviewed changes

mchavez-newrelic reviewed

View reviewed changes

src/content/docs/logs/ui-data/query-time-parsing.mdx Outdated Show resolved Hide resolved

Contributor

homelessbirds commented May 14, 2024

This is really wonderful, Rob. It's detailed, grounded, and concise.


          fix(logs): Obfuscate account and fix spacing.

5ec3e0d

rhetoric101 dismissed homelessbirds’s stale review via

5ec3e0d

May 14, 2024 22:19

rhetoric101 and others added 4 commits

May 14, 2024 15:22


          fix(logs): Switch out "string" for "values"

3a2845b

Co-authored-by: mchavez-newrelic <132291725+mchavez-newrelic@users.noreply.github.com>


          fix(logs): Clarify how the example works.

091e570

Co-authored-by: mchavez-newrelic <132291725+mchavez-newrelic@users.noreply.github.com>


          fix(logs): Add consistent capitalization of Grok

ff1fd14

Co-authored-by: mchavez-newrelic <132291725+mchavez-newrelic@users.noreply.github.com>


          fix(logs): Spell out regex and add new call to action

ac1d48c

mchavez-newrelic reviewed

View reviewed changes

src/content/docs/logs/ui-data/query-time-parsing.mdx Outdated Show resolved Hide resolved

rhetoric101 added 2 commits

May 14, 2024 17:08


          fix(logs): Obfuscate more images

78e5399


          fix(logs): Improve obfuscation in an image

7e6721c

rhetoric101 changed the title ~~Logs: Add query time parsing rules~~ (Publish 15 May 2024 at 9:00 AM) Logs: Add query time parsing rules

rhetoric101 moved this from Needs review to Scheduled work in Docs PRs and Issues

homelessbirds approved these changes

View reviewed changes

rhetoric101 added from_tw and removed from_internal labels

rhetoric101 merged commit ef1bc24 into develop

20 checks passed

rhetoric101 deleted the rhs-query-time-parsing branch

May 15, 2024 14:40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment