Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add scripted api test #17275

Merged
merged 4 commits into from May 17, 2024
Merged

add scripted api test #17275

merged 4 commits into from May 17, 2024

Conversation

keegoid-nr
Copy link
Contributor

Best practices example for scripted API monitors.

Copy link

Hi @keegoid-nr 👋

Thanks for your pull request! Your PR is in a queue, and a writer will take a look soon. We generally publish small edits within one business day, and larger edits within three days.

We will automatically generate a preview of your request, and will comment with a link when the preview is ready (usually 10 to 20 minutes).

Copy link

netlify bot commented May 11, 2024

Deploy Preview for docs-website-netlify ready!

Name Link
🔨 Latest commit 068b687
🔍 Latest deploy log https://app.netlify.com/sites/docs-website-netlify/deploys/6647ba5536cdfd00084c9aee
😎 Deploy Preview https://deploy-preview-17275--docs-website-netlify.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added this to Hero to triage in Docs PRs and Issues May 11, 2024
@jeff-colucci jeff-colucci added content requests related to docs site content from_internal Identifies issues/PRs from Relics (except writers) labels May 13, 2024
@jeff-colucci jeff-colucci self-assigned this May 13, 2024
@jeff-colucci
Copy link
Contributor

@keegoid-nr Seems like there are some questions and comments about the examples, once that stuff gets hammered out I'll be more than happy to review and merge!

@keegoid-nr
Copy link
Contributor Author

@jeff-colucci We are still working out where these advanced examples should go.

@jeff-colucci jeff-colucci moved this from Hero to triage to In progress in Docs PRs and Issues May 15, 2024
Best practices example for scripted API monitors.
- update steps from new UI process
- fix script with best practice changes from team suggestions
Copy link
Contributor

@jeff-colucci jeff-colucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw a few style things to tweak but other than that: looks good!

@jeff-colucci jeff-colucci merged commit 4c67658 into newrelic:develop May 17, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content requests related to docs site content from_internal Identifies issues/PRs from Relics (except writers)
Projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants