Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Commit

Permalink
Update to ESLint 5 (#1025)
Browse files Browse the repository at this point in the history
* Updates all dependencies to the latest available to pick up any
  ESLint 5 compatibility fixes (in the case of `babel-eslint` and
  `eslint-plugin-vue` this meant beta versions, so for those the
  tilde range has been changed to exact, pending the final versions).
* Raises `ecmaVersion` to `2018`.
* Removes all custom `ecmaFeatures` options since:
  - `impliedStrict` is redundant when using `sourceType: 'module'`
  - none of the others are recognised by latest ESLint/`babel-eslint`

Migration guide:
https://eslint.org/docs/user-guide/migrating-to-5.0.0

Docs to help with reviewing the `parserOptions` changes:
https://eslint.org/docs/user-guide/configuring#specifying-parser-options
https://github.com/babel/babel-eslint#configuration
https://eslint.org/docs/rules/strict#rule-details (for `impliedStrict`)

Fixes #383.
Closes #963.
Closes #1001.
  • Loading branch information
edmorley committed Aug 19, 2018
1 parent e683e37 commit 9ceebe7
Show file tree
Hide file tree
Showing 12 changed files with 249 additions and 371 deletions.
6 changes: 3 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,9 @@
"devDependencies": {
"auto-changelog": "^1.4.6",
"ava": "^1.0.0-beta.4",
"eslint": "^4.19.1",
"eslint-config-prettier": "^3.0.0",
"eslint-plugin-prettier": "^2.6.0",
"eslint": "^5.4.0",
"eslint-config-prettier": "^3.0.1",
"eslint-plugin-prettier": "^2.6.2",
"husky": "^0.14.3",
"jest": "^23.0.0",
"karma": "^3.0.0",
Expand Down
6 changes: 3 additions & 3 deletions packages/airbnb-base/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -24,11 +24,11 @@
},
"dependencies": {
"@neutrinojs/eslint": "9.0.0-0",
"eslint-config-airbnb-base": "^13.0.0",
"eslint-plugin-import": "^2.12.0"
"eslint-config-airbnb-base": "^13.1.0",
"eslint-plugin-import": "^2.14.0"
},
"peerDependencies": {
"eslint": "^4.0.0",
"eslint": "^5.0.0",
"neutrino": "^9.0.0-0",
"webpack": "^4.0.0"
}
Expand Down
12 changes: 6 additions & 6 deletions packages/airbnb/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -24,14 +24,14 @@
},
"dependencies": {
"@neutrinojs/eslint": "9.0.0-0",
"eslint-config-airbnb": "^17.0.0",
"eslint-config-airbnb-base": "^13.0.0",
"eslint-plugin-import": "^2.12.0",
"eslint-plugin-jsx-a11y": "^6.0.3",
"eslint-plugin-react": "^7.9.1"
"eslint-config-airbnb": "^17.1.0",
"eslint-config-airbnb-base": "^13.1.0",
"eslint-plugin-import": "^2.14.0",
"eslint-plugin-jsx-a11y": "^6.1.1",
"eslint-plugin-react": "^7.11.1"
},
"peerDependencies": {
"eslint": "^4.0.0",
"eslint": "^5.0.0",
"neutrino": "^9.0.0-0",
"webpack": "^4.0.0"
}
Expand Down
2 changes: 1 addition & 1 deletion packages/create-project/commands/init/matrix.js
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ const AIRBNB = '@neutrinojs/airbnb';
const AIRBNB_BASE = '@neutrinojs/airbnb-base';
const STANDARDJS = '@neutrinojs/standardjs';

const ESLINT = 'eslint@^4';
const ESLINT = 'eslint@^5';
const WEBPACK = 'webpack@^4';
const WEBPACK_CLI = 'webpack-cli@^2';
const WEBPACK_DEV_SERVER = 'webpack-dev-server@^3';
Expand Down
9 changes: 2 additions & 7 deletions packages/eslint/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -52,13 +52,8 @@ neutrino.use(eslint, {
envs: ['es6'],
parser: 'babel-eslint',
parserOptions: {
ecmaVersion: 2017,
sourceType: 'module',
ecmaFeatures: {
objectLiteralDuplicateProperties: false,
generators: true,
impliedStrict: true
}
ecmaVersion: 2018,
sourceType: 'module'
},
settings: {},
globals: ['process'],
Expand Down
9 changes: 2 additions & 7 deletions packages/eslint/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -98,13 +98,8 @@ module.exports = (neutrino, opts = {}) => {
envs: ['es6'],
parser: require.resolve('babel-eslint'),
parserOptions: {
ecmaVersion: 2017,
sourceType: 'module',
ecmaFeatures: {
objectLiteralDuplicateProperties: false,
generators: true,
impliedStrict: true
}
ecmaVersion: 2018,
sourceType: 'module'
},
settings: {},
globals: ['process'],
Expand Down
6 changes: 3 additions & 3 deletions packages/eslint/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -23,16 +23,16 @@
"yarn": ">=1.2.1"
},
"dependencies": {
"babel-eslint": "^8.2.3",
"babel-eslint": "9.0.0-beta.3",
"debug": "^3.1.0",
"deepmerge": "^1.5.2",
"eslint-loader": "^2.0.0",
"eslint-loader": "^2.1.0",
"eslint-plugin-babel": "^5.1.0",
"lodash.clonedeep": "^4.5.0",
"lodash.omit": "^4.5.0"
},
"peerDependencies": {
"eslint": "^4.0.0",
"eslint": "^5.0.0",
"neutrino": "^9.0.0-0",
"webpack": "^4.0.0"
}
Expand Down
2 changes: 1 addition & 1 deletion packages/jest/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
"@neutrinojs/compile-loader": "9.0.0-0",
"@neutrinojs/loader-merge": "9.0.0-0",
"babel-plugin-jest-hoist": "^23.0.0",
"eslint-plugin-jest": "^21.15.1",
"eslint-plugin-jest": "^21.21.0",
"lodash.omit": "^4.5.0"
},
"peerDependencies": {
Expand Down
2 changes: 1 addition & 1 deletion packages/react/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
"@neutrinojs/loader-merge": "9.0.0-0",
"@neutrinojs/web": "9.0.0-0",
"deepmerge": "^1.5.2",
"eslint-plugin-react": "^7.9.1"
"eslint-plugin-react": "^7.11.1"
},
"devDependencies": {
"react": "*",
Expand Down
8 changes: 4 additions & 4 deletions packages/standardjs/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -27,14 +27,14 @@
"@neutrinojs/eslint": "9.0.0-0",
"eslint-config-standard": "^11.0.0",
"eslint-config-standard-jsx": "^5.0.0",
"eslint-plugin-import": "^2.12.0",
"eslint-plugin-node": "^6.0.1",
"eslint-plugin-import": "^2.14.0",
"eslint-plugin-node": "^7.0.1",
"eslint-plugin-promise": "^4.0.0",
"eslint-plugin-react": "^7.9.1",
"eslint-plugin-react": "^7.11.1",
"eslint-plugin-standard": "^3.1.0"
},
"peerDependencies": {
"eslint": "^4.0.0",
"eslint": "^5.0.0",
"neutrino": "^9.0.0-0"
}
}
4 changes: 2 additions & 2 deletions packages/vue/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,8 @@
"@neutrinojs/web": "9.0.0-0",
"css-loader": "^1.0.0",
"deepmerge": "^1.5.2",
"eslint-plugin-react": "^7.9.1",
"eslint-plugin-vue": "^4.5.0",
"eslint-plugin-react": "^7.11.1",
"eslint-plugin-vue": "5.0.0-beta.3",
"stylelint-processor-html": "^1.0.0",
"vue-loader": "^15.0.0",
"vue-style-loader": "^4.1.0",
Expand Down

0 comments on commit 9ceebe7

Please sign in to comment.