Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pin packaging==21.3 #2707

Merged
merged 1 commit into from Feb 5, 2024
Merged

pin packaging==21.3 #2707

merged 1 commit into from Feb 5, 2024

Conversation

heerener
Copy link
Collaborator

@heerener heerener commented Feb 5, 2024

22.0 dropped LegacyVersion: pypa/packaging#407
This makes it so our branches can no longer be parsed as versions

22.0 dropped LegacyVersion: pypa/packaging#407
This makes it so our branches can no longer be parsed as versions
Copy link

sonarcloud bot commented Feb 5, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Member

@pramodk pramodk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

(@heerener : just a note, it's also part of the #2706)

Copy link

codecov bot commented Feb 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b4c5480) 46.51% compared to head (bd57b4e) 46.47%.

Additional details and impacted files
@@               Coverage Diff               @@
##           release/8.2    #2707      +/-   ##
===============================================
- Coverage        46.51%   46.47%   -0.05%     
===============================================
  Files              527      527              
  Lines           119267   119267              
===============================================
- Hits             55474    55424      -50     
- Misses           63793    63843      +50     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@heerener heerener enabled auto-merge (squash) February 5, 2024 16:06
Copy link

✔️ bd57b4e -> Azure artifacts URL

@heerener heerener merged commit 8e483a9 into release/8.2 Feb 5, 2024
36 of 37 checks passed
@heerener heerener deleted the 8.2.4a branch February 5, 2024 16:47
@heerener heerener mentioned this pull request Feb 6, 2024
26 tasks
JCGoran pushed a commit that referenced this pull request Feb 7, 2024
22.0 dropped LegacyVersion: pypa/packaging#407
This makes it so our branches can no longer be parsed as versions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants