Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some more changes to make pytest-randomly happy #5719

Merged
merged 2 commits into from Jun 9, 2022

Conversation

MridulS
Copy link
Member

@MridulS MridulS commented Jun 9, 2022

After this is merged we should be able to merge #4553, it passed locally on a bunch of runs after these changes.

Copy link
Contributor

@rossbar rossbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @MridulS . Longer term it'd be great to make these tests less state-ful :)

@dschult dschult merged commit 11f338b into networkx:main Jun 9, 2022
@jarrodmillman jarrodmillman added this to the networkx-2.8.4 milestone Jun 9, 2022
MridulS added a commit to MridulS/networkx that referenced this pull request Feb 4, 2023
* Compare edges without worrying about order to work with pytest-randomly

* add another revert to make pytest randomly pass
cvanelteren pushed a commit to cvanelteren/networkx that referenced this pull request Apr 22, 2024
* Compare edges without worrying about order to work with pytest-randomly

* add another revert to make pytest randomly pass
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants