Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes Github Actions failures #4548

Merged
merged 1 commit into from
Jan 20, 2021
Merged

fixes Github Actions failures #4548

merged 1 commit into from
Jan 20, 2021

Conversation

dpfens
Copy link
Contributor

@dpfens dpfens commented Jan 20, 2021

Github Actions failing due to new release of pyyaml==5.4 this change will ensure that version 5.3 is used. There may be a better/simpler way to account for this issue, just let me know.

@stefanv
Copy link
Contributor

stefanv commented Jan 20, 2021

👋 @dpfens, thanks for the fix! I don't think we can pin to such a specific range of pyyaml, so could we rather address the error introduced?

Github Actions failing due to new release of pyyaml==5.4, this change should resolve that issue
@dpfens
Copy link
Contributor Author

dpfens commented Jan 20, 2021

@stefanv Makes sense. Changing this line to use the yaml.Loader instead of yaml.FullLoader no longer raises the error. yaml.BaseLoader should also work, but it could introduce new issues.

@stefanv
Copy link
Contributor

stefanv commented Jan 20, 2021

This seems to be an ongoing issue for PyYAML; the issue @dpfens mentioned above is also the one that tracks this problem. They sorted it out in 5.2 apparently, and now it is appearing again.

@dpfens Thanks for addressing, this seems like a fine workaround (strictly speaking unnecessary, but that's for PyYAML to address).

@dschult dschult merged commit a6dd458 into networkx:master Jan 20, 2021
@jarrodmillman
Copy link
Member

LGTM. We are removing networkx/readwrite/nx_yaml.py, so in a a couple months we won't have to worry about this anymore.

rossbar added a commit to jarrodmillman/networkx that referenced this pull request Feb 4, 2021
@jarrodmillman jarrodmillman added this to the networkx-2.6 milestone May 20, 2021
MridulS pushed a commit to MridulS/networkx that referenced this pull request Feb 4, 2023
Github Actions failing due to new release of pyyaml==5.4, this change should resolve that issue
cvanelteren pushed a commit to cvanelteren/networkx that referenced this pull request Apr 22, 2024
Github Actions failing due to new release of pyyaml==5.4, this change should resolve that issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants