Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

We need to use NewGloblRef when caching jclass instances #9595

Merged
merged 2 commits into from Sep 23, 2019
Merged

We need to use NewGloblRef when caching jclass instances #9595

merged 2 commits into from Sep 23, 2019

Commits on Sep 23, 2019

  1. We need to use NewGloblRef when caching jclass instances 

    Motivation:

It is not safe to cache a jclass without obtaining a global reference via NewGlobalRef.

Modifications:

Correctly use NewGlobalRef(...) before caching

Result:

Correctly cache jclass instance
    @normanmaurer
    normanmaurer committed Sep 23, 2019
    Copy the full SHA
    8438501 View commit details
    Browse the repository at this point in the history

  2. Update netty_kqueue_bsdsocket.c

    @normanmaurer
    normanmaurer committed Sep 23, 2019
    Copy the full SHA
    6ef3ce5 View commit details
    Browse the repository at this point in the history