Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ChunkedNioFile can use absolute FileChannel::read to read chunks #9592

Merged
merged 1 commit into from Sep 24, 2019
Merged

ChunkedNioFile can use absolute FileChannel::read to read chunks #9592

merged 1 commit into from Sep 24, 2019

Commits on Sep 23, 2019

  1. ChunkedNioFile can use absolute FileChannel::read to read chunks 

    Motivation:

Users can reuse the same FileChannel for different ChunkedNioFile
instances without being worried that FileChannel::position will be
changed concurrently by them.
In addition, FileChannel::read with absolute position allows to
use on *nix pread that is more efficient then fread.

Modifications:

Always use absolute FileChannel::read ops

Result:

Faster and more flexible uses of FileChannel for ChunkedNioFile
    @franz1981
    franz1981 committed Sep 23, 2019
    Copy the full SHA
    da8d633 View commit details
    Browse the repository at this point in the history