Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix *SslEngineTest to not throw ClassCastException and pass in all cases #9588

Merged
merged 1 commit into from Sep 21, 2019
Merged

Fix *SslEngineTest to not throw ClassCastException and pass in all cases #9588

merged 1 commit into from Sep 21, 2019

Commits on Sep 21, 2019

  1. Fix *SslEngineTest to not throw ClassCastException and pass in all cases 

    Motivation:

Due some bug we did endup with ClassCastExceptions in some cases. Beside this we also did not correctly handle the case when ReferenceCountedOpenSslEngineTest did produce tasks to run in on test.

Modifications:

- Correctly unwrap the engine before to fix ClassCastExceptions
- Run delegated tasks when needed.

Result:

All tests pass with different OpenSSL implementations (OpenSSL, BoringSSL etc)
    @normanmaurer
    normanmaurer committed Sep 21, 2019
    Copy the full SHA
    ae413aa View commit details
    Browse the repository at this point in the history