Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTTP2: Guard against empty DATA frames (without end_of_stream flag) set #9461

Merged
merged 1 commit into from Aug 13, 2019
Merged

HTTP2: Guard against empty DATA frames (without end_of_stream flag) set #9461

merged 1 commit into from Aug 13, 2019

Commits on Aug 13, 2019

  1. HTTP2: Guard against empty DATA frames (without end_of_stream flag) set 

    Motivation:

It is possible for a remote peer to flood the server / client with empty DATA frames (without end_of_stream flag) set and so cause high CPU usage without the possibility to ever hit a limit. We need to guard against this.

See CVE-2019-9518

Modifications:

- Add a new config option to AbstractHttp2ConnectionBuilder and sub-classes which allows to set the max number of consecutive empty DATA frames (without end_of_stream flag). After this limit is hit we will close the connection. A limit of 10 is used by default.
- Add unit tests

Result:

Guards against CVE-2019-9518
    @normanmaurer
    normanmaurer committed Aug 13, 2019
    Copy the full SHA
    da616ba View commit details
    Browse the repository at this point in the history