Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always wrap X509ExtendedTrustManager when using OpenSSL and JDK < 11 #9443

Merged
merged 1 commit into from Aug 13, 2019
Merged

Always wrap X509ExtendedTrustManager when using OpenSSL and JDK < 11 #9443

merged 1 commit into from Aug 13, 2019

Commits on Aug 12, 2019

  1. Always wrap X509ExtendedTrustManager when using OpenSSL and JDK < 11 

    Motivation:

When using OpenSSL and JDK < 11 is used we need to wrap the user provided X509ExtendedTrustManager to be able to support TLS1.3. We had a check in place that first tried to see if wrapping is needed at all which could lead to missleading calls of the user provided trustmanager. We should remove these calls and just always wrap if needed.

Modifications:

Always wrap if OpenSSL + JDK < 11 and TLS1.3 is supported

Result:

Less missleading calls to user provided trustmanager
    @normanmaurer
    normanmaurer committed Aug 12, 2019
    Copy the full SHA
    1d5de39 View commit details
    Browse the repository at this point in the history