Fixed incorrect Sec-WebSocket-Origin header for v13, see #9134 #9312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
@netty-bot test this please |
|
/cc @vietj |
normanmaurer
approved these changes
Jul 2, 2019
|
@slandelle ping... |
slandelle
approved these changes
Jul 12, 2019
|
LGTM |
normanmaurer
approved these changes
Jul 12, 2019
|
@amizurov thanks a lot! |
normanmaurer
pushed a commit
that referenced
this pull request
Jul 12, 2019
Motivation: Based on https://tools.ietf.org/html/rfc6455#section-1.3 - for non-browser clients, Origin header field may be sent if it makes sense in the context of those clients. Modification: Replace Sec-WebSocket-Origin to Origin Result: Fixes #9134 .
|
Hi, |
|
Can you open a PR for this ?
… Am 06.08.2019 um 17:29 schrieb marci74 ***@***.***>:
Hi,
we are using netty as a web socket client (through vert.x). In our tests we fake the "origin" header. This does not work anymore with version 4.1.38 since you always overwrite our custom the "origin" header. Could you please set the header conditionally (only if it does not already exist in the custom headers)?
Thanks.
Marc
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
Hi guys, could you please check the #9435 |
|
@amizurov Looks good. Thank you very much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Based on https://tools.ietf.org/html/rfc6455#section-1.3 - for non-browser
clients,
Originheader field may be sent if it makes sense in the context of those clients.Modification:
Replace
Sec-WebSocket-OrigintoOriginResult:
Fixes #9134 .