Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to new netty-build and com.puppycrawl.tools 8.18 #8980

Merged
merged 1 commit into from Mar 26, 2019

Conversation

normanmaurer
Copy link
Member

Motivation:

com.puppycrawl.tools checkstyle < 8.18 was reported to contain a possible security flaw. We should upgrade.

Modifications:

  • Upgrade netty-build and checkstyle.
  • Fix checkstyle errors

Result:

Fixes #8968.

@normanmaurer normanmaurer added this to the 4.1.35.Final milestone Mar 26, 2019
Copy link
Member

@trustin trustin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Motivation:

com.puppycrawl.tools checkstyle < 8.18 was reported to contain a possible security flaw. We should upgrade.

Modifications:

- Upgrade netty-build and checkstyle.
- Fix checkstyle errors

Result:

Fixes #8968.
@normanmaurer normanmaurer merged commit 8206604 into 4.1 Mar 26, 2019
@normanmaurer normanmaurer deleted the upgrade_checkstyle branch March 26, 2019 13:21
normanmaurer added a commit that referenced this pull request Mar 26, 2019
Motivation:

com.puppycrawl.tools checkstyle < 8.18 was reported to contain a possible security flaw. We should upgrade.

Modifications:

- Upgrade netty-build and checkstyle.
- Fix checkstyle errors

Result:

Fixes #8968.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants