Fix unbounded expansion of cumulative buffer in SslHandler #5932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: 62057f7 introduced a regression where large amounts of memory could accumulate, and not be cleaned up in a timely manner. Modifications: - Call super.channelReadComplete() instead of calling ctx.fireChannelReadComplete() Result: Fixes netty#5928
|
@svnp10 @slandelle @trustin - FYI |
|
@Scottmitch actually not LGTM... we already call discardSomeReadBytes() which should handle the problem. Calling super.channelReadComplete() is not necessary. So I |
@normanmaurer - Good point. Let me close this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
62057f7 introduced a regression where large amounts of memory could accumulate, and not be cleaned up in a timely manner.
Modifications:
Result:
Fixes #5928