Always send ChannelInputShutdownReadComplete in epoll #14042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Made it a draft for now, because I can't run some of the tests in my dev container, so I don't know if this breaks anything or not. Also, there's a commented-out piece of code that also appears to fix the EpollSocketHalfClosedTest. |
|
Can you point me to the commented code that also fixes it ? Strangely enough it never fails here 🤦♂️🤷♂️ |
This change: |
|
Without this change, it fails for me roughly one in 30 runs. |
|
Thanks... will have a closer look tomorrow morning |
normanmaurer
requested changes
May 10, 2024
transport-classes-epoll/src/main/java/io/netty/channel/epoll/AbstractEpollChannel.java
Outdated
Show resolved
Hide resolved
Motivation: We were observing EpollSocketHalfClosedTest was occasionally failing. This appears to be because we were clearing EPOLLIN when we shouldn't, and prevent ourselves from getting the RDHUP where we send the ChannelInputShutdownReadComplete event. Modification: Predicate the `clearEpollIn0()` call on `shouldStopReading(config())`, so we continue to try reading when reads are queued. This allows us to get another RDHUP which we will turn into the read-complete event. Result: We no longer miss out on read-complete events from input shut down.
chrisvest
force-pushed
the
4.2-lt-half-closed
branch
from
9e1cc27
to
0d6d28d
Compare
|
@normanmaurer Build is happy with the change. (I think the Graal failure is something else) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
We were observing EpollSocketHalfClosedTest was occasionally failing.
This appears to be because we were clearing EPOLLIN when we shouldn't, and prevent ourselves from getting the RDHUP where we send the ChannelInputShutdownReadComplete event.
Modification:
Predicate the
clearEpollIn0()call onshouldStopReading(config()), so we continue to try reading when reads are queued.This allows us to get another RDHUP which we will turn into the read-complete event.
Result:
We no longer miss out on read-complete events from input shut down.